Skip to content

Enable diagnostic attributes for Rust 1.78+#2693

Merged
seanmonstar merged 1 commit intomainfrom
jplatte/diagnostic-ver
Apr 30, 2024
Merged

Enable diagnostic attributes for Rust 1.78+#2693
seanmonstar merged 1 commit intomainfrom
jplatte/diagnostic-ver

Conversation

@jplatte
Copy link
Member

@jplatte jplatte commented Mar 31, 2024

Stabilized for 1.78 in rust-lang/rust#119888.

@tisonkun does this fix your issue? You can try it by adding

[patch.crates-io]
axum = { git = "https://github.com/tokio-rs/axum", branch = "jplatte/diagnostic-ver" }
axum-core = { git = "https://github.com/tokio-rs/axum", branch = "jplatte/diagnostic-ver" }

to your top-level Cargo.toml (the workspace file if you use a Cargo workspace).

@jplatte jplatte requested a review from davidpdrsn March 31, 2024 18:09
tisonkun
tisonkun approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed.

With this patch, it compiles; otherwise, it can't.

Thank you!

@jplatte jplatte mentioned this pull request Apr 20, 2024
Closed
@aumetra aumetra mentioned this pull request Apr 24, 2024
Merged
4 tasks
@seanmonstar
Copy link
Member

seanmonstar commented Apr 30, 2024

Does adding this new proc macro slow down compilation?

@jplatte
Copy link
Member Author

jplatte commented Apr 30, 2024

We were already using rustversion, just in a build script. By using it in the crate directly and deleting the build script, I would expect things to become slightly faster since every build script has cargo spawn a separate compiler process, then the build script process.

@seanmonstar seanmonstar merged commit 5201798 into main Apr 30, 2024
@seanmonstar seanmonstar deleted the jplatte/diagnostic-ver branch April 30, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

@yanns yanns yanns approved these changes

@davidpdrsn davidpdrsn Awaiting requested review from davidpdrsn

+1 more reviewer

@tisonkun tisonkun tisonkun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jplatte @seanmonstar @yanns @tisonkun